Skip to content

Fix deleted_tasks field type in TaskDeletion struct #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025

Conversation

coinmoles
Copy link

Pull Request

Related issue

Fixes #665

What does this PR do?

  • Change the type of deleted_tasks field in TaskDeletion from usize to Option<usize>
    • This should be Option<usize> since it can be null according to the API documentation

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@Mubelotix Mubelotix changed the base branch from main to dev July 11, 2025 14:54
Copy link
Collaborator

@Mubelotix Mubelotix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you

@Mubelotix Mubelotix merged commit b175a09 into meilisearch:dev Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TaskDeletion struct has incorrect type for field deleted_tasks
2 participants